Correcting minimum bid amount to 10_000 CSPR from 100_000 CSPR#5158
Merged
sacherjj merged 1 commit intocasper-network:devfrom Mar 13, 2025
Merged
Conversation
sacherjj
requested review from
EdHastingsCasperAssociation,
darthsiroftardis and
mrkara
mrkara
approved these changes
Mar 13, 2025
Contributor
mrkara
left a comment
mrkara
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Also, we should inform/warn the validators about this new chainspec value and its behavior because it can practically kill a validator if they don't have this minimum amount at the point of upgrade or if they go below this amount at some point after the upgrade.
mpapierski
reviewed
Mar 13, 2025
| # Minimum bid amount allowed in motes. Withdrawing one's bid to an amount strictly less than | ||
| # the value specified will be treated as a full unbond of a validator and their associated delegators | ||
| minimum_bid_amount = 100_000_000_000_000 | ||
| minimum_bid_amount = 10_000_000_000_000 |
Collaborator
There was a problem hiding this comment.
We need local chainspec to stay in sync with this value
darthsiroftardis
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider the following when creating a PR: